Fix event name search filter on admin activities page#1347
Merged
Conversation
The view passed params[:name] from the Event Name text field but the controller never used it to filter results. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/fix-event-name-search
branch
from
3cd82ad to
3efc522
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
/admin/activities/eventswas not filtering results at allparams[:name]but the controller never applied it as a filterHow did you approach the change?
LIKEquery filter inAhoyActivitiesController#indexthat does substring matching onahoy_events.namesanitize_sql_liketo prevent SQL injection from wildcard charactersUI Testing Checklist
/admin/activities/events, type an event name (e.g. "auth.login"), click Filter — only matching events appearAnything else to add?
N/A
🤖 Generated with Claude Code